Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: typing issues surfaced by typescript 3.7 #260

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Nov 20, 2019

🐛 Bug Fix

After upgrading to [email protected], several issues show up.

@kristw kristw requested a review from a team as a code owner November 20, 2019 06:43
@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #260 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #260   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         104    104           
  Lines        1233   1230    -3     
  Branches      297    296    -1     
=====================================
- Hits         1233   1230    -3
Impacted Files Coverage Δ
...rset-ui-chart/src/components/ChartDataProvider.tsx 100% <100%> (ø) ⬆️
...kages/superset-ui-chart/src/clients/ChartClient.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ebf71...2439dd2. Read the comment docs.

@netlify
Copy link

netlify bot commented Nov 20, 2019

Deploy preview for superset-ui ready!

Built with commit 2439dd2

https://deploy-preview-260--superset-ui.netlify.com

@kristw kristw requested a review from etr2460 November 20, 2019 06:58
Copy link
Contributor

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kristw kristw merged commit a72c3dd into master Nov 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--fix-type branch November 20, 2019 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants