Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Update color module #22

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Update color module #22

merged 3 commits into from
Nov 6, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Nov 5, 2018 •
edited
Loading

🏆 Enhancements

  • Add BRAND_COLOR constant
  • Add functionality to SequentialScheme to replace colorScalerFactory in colors.js

@codecov
Copy link

codecov bot commented Nov 5, 2018 •
edited
Loading

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          29     30    +1     
  Lines         249    260   +11     
=====================================
+ Hits          249    260   +11
Impacted Files Coverage Δ
packages/superset-ui-color/src/index.js 100% <100%> (ø)
packages/superset-ui-color/src/SequentialScheme.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9518660...0f82385. Read the comment docs.

@kristw kristw changed the title Add BRAND_COLOR constant Update color module Nov 5, 2018
@kristw kristw self-assigned this Nov 5, 2018
@kristw kristw added the reviewable Ready for review label Nov 5, 2018
williaster
williaster approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌈

xtinec
xtinec approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@xtinec xtinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. :shipit:

@kristw kristw merged commit 28bcd47 into master Nov 6, 2018
@kristw kristw deleted the kristw--brand-color branch November 6, 2018 01:14
@kristw kristw added this to the v0.4.0 milestone Nov 13, 2018
@kristw kristw added reviewable Ready for review and removed reviewable Ready for review labels Nov 13, 2018
@kristw kristw added the #enhancement New feature or request label Dec 6, 2018
kristw added a commit that referenced this pull request Apr 17, 2020
@kristw
fix: y axis bounds when input are nan (#22)
545fd81 
* fix: avoid computing log for 0

* fix: y axis bounds when input are nan
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@williaster williaster williaster approved these changes

@xtinec xtinec xtinec approved these changes

@conglei conglei Awaiting requested review from conglei

Assignees

@kristw kristw

Labels
#enhancement New feature or request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kristw @xtinec @williaster