This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix: React.Fragment complaining about width/height #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 130 130
Lines 1416 1416
Branches 358 358
=======================================
Hits 1415 1415
Partials 1 1
Continue to review full report at Codecov.
|
|
Deploy preview for superset-ui ready! Built with commit ae63ea3 |
williaster
approved these changes
Sep 4, 2019
There was a problem hiding this comment.
ah, I think typical Components don't complain if you add extra props, but have also seen custom React prop validators like forbidExtraProps that do throw errors when you pass unknown props. They must do something like that, they're pretty good with mis-use warnings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Passing
widthandheighttoReact.Fragmentcause the console to print out warnings about unexpected props.