Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: remove is_prequery and prequeries #208

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Aug 23, 2019

🐛 Bug Fix

Superset 0.34 removed fields is_prequery and prequeries from the APIs.
Sending query objects with these fields to the backend will result in error 500.

@kristw kristw requested a review from a team as a code owner August 23, 2019 18:39
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         111      111           
  Lines        1239     1239           
  Branches      303      303           
=======================================
  Hits         1238     1238           
  Partials        1        1
Impacted Files Coverage Δ
packages/superset-ui-query/src/buildQueryObject.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b690b...e0879e6. Read the comment docs.

@netlify
Copy link

netlify bot commented Aug 23, 2019

Deploy preview for superset-ui ready!

Built with commit e0879e6

https://deploy-preview-208--superset-ui.netlify.com

@kristw kristw added the reviewable Ready for review label Aug 25, 2019
@kristw kristw merged commit ddaf104 into master Aug 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--strip-prequery branch August 26, 2019 18:03
kristw pushed a commit that referenced this pull request Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
reviewable Ready for review size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants