Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoPush needs more control #20

Open
SaulDoesCode opened this issue Nov 17, 2018 · 3 comments
Open

AutoPush needs more control #20

SaulDoesCode opened this issue Nov 17, 2018 · 3 comments

Comments

@SaulDoesCode
Copy link
Contributor

the <link> tag has several variations which don't always need pushing for example with preload/favicon pushing can disturb caching and cause needless bandwidth consumption and sometimes in the worst cases duplicate requests, so there should be a bit more specificity and potentially a feature to exclude/omit certain paths from the push list, (immutable/async cached assets assets that are very big)

see transplacer's take on this matter.

@SaulDoesCode SaulDoesCode changed the title AutoPush need's more control AutoPush needs more control Nov 17, 2018
@aofei
Copy link
Owner

aofei commented Nov 19, 2018

Yeah, you are right. It seems that the AutoPush feature needs to be refined. I'll take the time to study it in a few days.

BTW, you made a mistake in the transplacer, I'm fixing it, you'll see.

@aofei
Copy link
Owner

aofei commented Nov 19, 2018

Hi @SaulDoesCode,

See my new commit 7c0d0bb.

@SaulDoesCode
Copy link
Contributor Author

Awesome, everyday something is getting better. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants