Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundlemon reports incorrect size deltas when using stacked PRs #70

Open
steveluscher opened this issue Jan 20, 2025 · 1 comment · May be fixed by #71
Open

Bundlemon reports incorrect size deltas when using stacked PRs #70

steveluscher opened this issue Jan 20, 2025 · 1 comment · May be fixed by #71

Comments

@steveluscher
Copy link
Collaborator

Bundlemon is a CI step that compiles the code and then compares the size of key compiled bundles with the mergebase. Unfortunately when you stack a PR (ie. with Graphite) the mergebase is the PR before it. Bundlemon has no knowledge of such a branch and thinks that every file has been added anew.

The fix will be to get Bundlemon to use the root branch as the mergebase. Or I guess just always main.
@steveluscher
Copy link
Collaborator Author

Example PR that had an incorrect Bundlemon report: https://app.graphite.dev/github/pr/anza-xyz/solana-web3.js/69/Run-style-fix

@steveluscher steveluscher linked a pull request Jan 20, 2025 that will close this issue
Draft
steveluscher added a commit that referenced this issue Jan 20, 2025
@steveluscher
NOT FOR COMMIT: Test adding data to bundle
d4b7ed6 
Stack this on top of `bundlemon-always-against-main` and see if Bundlemon reports the correct size.

See #70
@steveluscher steveluscher mentioned this issue Jan 20, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always compare the current PR's bundle size to main anza-xyz/solana-web3.js
1 participant
@steveluscher