v1.18: Add --with-compute-unit-price to cli program deploy commands (backport of #364)
#392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* add set compute units arg for program deploy * update master changes * remove duplicates * fixes and tests * remove extra lines * feedback * Use simulation to determine compute units consumed * feedback --------- Co-authored-by: NagaprasadVr <[email protected]> (cherry picked from commit 2ee606d)
joncinque
approved these changes
Mar 22, 2024
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
… (backport of anza-xyz#364) (anza-xyz#392) Add `--with-compute-unit-price` to cli program deploy commands (anza-xyz#364) * add set compute units arg for program deploy * update master changes * remove duplicates * fixes and tests * remove extra lines * feedback * Use simulation to determine compute units consumed * feedback --------- Co-authored-by: NagaprasadVr <[email protected]> (cherry picked from commit 2ee606d) Co-authored-by: Justin Starry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's not possible to set a compute unit price or limit on deploy transactions. This causes deploys to be very slow when transaction priority fees increase on the cluster.
Summary of Changes
--with-compute-unit-priceflag is passed forsolana program deployandsolana program write-bufferFixes #21
This is an automatic backport of pull request #364 done by [Mergify](https://mergify.com).