Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[svm] add ed25519 and secp256r1 logic to precompile tests #3877

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

samkim-crypto
Copy link

@samkim-crypto samkim-crypto commented Dec 3, 2024

Problem

Secp256r1 precompile was added (#3152), but the precompile tests in svm does not include it.

Summary of Changes

I included secp256r1 in the precompile tests. I noticed that ed25519 precompile was also missing, so I added that too.

I also swapped out rand with an older rand0-7 in the dev dependency to simplify the key generation a little, but I can revert this if suggested.

Fixes #

@vadorovsky vadorovsky self-requested a review December 3, 2024 07:52
@samkim-crypto samkim-crypto marked this pull request as ready for review December 3, 2024 08:56
@samkim-crypto samkim-crypto requested a review from a team as a code owner December 3, 2024 08:56
Copy link

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@samkim-crypto samkim-crypto merged commit f833179 into anza-xyz:master Dec 3, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants