-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.18: Fix: deploy program on last slot of epoch during environment change (backport of #101) #387
Conversation
Cherry-pick of 91b1ee3 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
…101) * Fix: deploy program on last slot of epoch during environment change * solana-runtime: deploy at last epoch slot test * disable deployment of sol_alloc_free * Move tx-batch-constructor to its own function * use new_from_cache --------- Co-authored-by: Alessandro Decina <[email protected]> (cherry picked from commit 91b1ee3)
0650b5e
to
9012ccd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #387 +/- ##
========================================
Coverage 81.5% 81.6%
========================================
Files 827 827
Lines 224453 224590 +137
========================================
+ Hits 183132 183292 +160
+ Misses 41321 41298 -23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for backport to beta
…hange (backport of anza-xyz#101) (anza-xyz#387)
Problem
On runtime environment change, the program deployed in the last slot of the prior epoch will use incorrect environment. This will also prevent the loading of the program in future epochs with the correct runtime environment.
Summary of Changes
The problem happens because the effective slot for the deployed program is in the next epoch, where the new environment becomes effective.
This change updates the program deployment procedure, to use the environment of the epoch where the program actually becomes effective.
Fixes #
This is an automatic backport of pull request #101 done by [Mergify](https://mergify.com).