Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: show max vote credits in vote-account based on TVC activation epoch #3776

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

AshwinSekar
Copy link

@AshwinSekar AshwinSekar commented Nov 25, 2024

Problem

Show vote account CLI compares the credits earned vs slots in epoch.
This is a faulty comparison as with TVC validators can earn up to 16 credits per slot.

Summary of Changes

Add a multiplier based on whether TVC was active in that epoch for a fair comparison

@AshwinSekar AshwinSekar added v2.1 Backport to v2.1 branch v2.0 Backport to v2.0 branch labels Nov 25, 2024
Copy link

mergify bot commented Nov 25, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

Copy link

mergify bot commented Nov 25, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

@AshwinSekar AshwinSekar added the automerge automerge Merge this Pull Request automatically once CI passes label Nov 25, 2024
Copy link

mergify bot commented Nov 25, 2024

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge automerge Merge this Pull Request automatically once CI passes label Nov 25, 2024
@AshwinSekar AshwinSekar added the automerge automerge Merge this Pull Request automatically once CI passes label Nov 25, 2024
@mergify mergify bot merged commit b543f25 into anza-xyz:master Nov 25, 2024
42 checks passed
mergify bot pushed a commit that referenced this pull request Nov 25, 2024
mergify bot pushed a commit that referenced this pull request Nov 25, 2024
AshwinSekar added a commit that referenced this pull request Nov 25, 2024
AshwinSekar added a commit that referenced this pull request Nov 25, 2024
AshwinSekar added a commit that referenced this pull request Nov 25, 2024
AshwinSekar added a commit that referenced this pull request Nov 26, 2024
@AshwinSekar AshwinSekar deleted the cli-vote-credits branch November 26, 2024 15:21
AshwinSekar added a commit that referenced this pull request Nov 26, 2024
AshwinSekar added a commit that referenced this pull request Nov 26, 2024
AshwinSekar added a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes v2.0 Backport to v2.0 branch v2.1 Backport to v2.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants