Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: introduce ci/docker/env.sh #3774

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

yihau
Copy link
Member

@yihau yihau commented Nov 25, 2024

Problem

context: https://discord.com/channels/428295358100013066/560503042458517505/1310571536221995068

it's time to update our ci to ubuntu 22

Summary of Changes

  • move all docker related env into ci/docker/env.sh
  • use a new tag format for our ci docker image.
CI_DOCKER_IMAGE="anzaxyz/ci:${SANITIZED_BASE_IMAGE}_rust-${RUST_VERSION}_${RUST_NIGHTLY_VERSION}_${ci_docker_hash}"`

@brooksprumo
Copy link

I'm not sure how to review this for correctness nor security, so I'm removing myself as a reviewer.

@brooksprumo brooksprumo requested review from t-nelson and removed request for brooksprumo November 25, 2024 16:10
@yihau yihau added automerge automerge Merge this Pull Request automatically once CI passes v2.1 Backport to v2.1 branch labels Nov 25, 2024
Copy link

mergify bot commented Nov 25, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@anza-team
Copy link
Collaborator

😱 New commits were pushed while the automerge label was present.

@anza-team anza-team removed the automerge automerge Merge this Pull Request automatically once CI passes label Nov 25, 2024
@LucasSte LucasSte added the automerge automerge Merge this Pull Request automatically once CI passes label Nov 25, 2024
Copy link

mergify bot commented Nov 25, 2024

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge automerge Merge this Pull Request automatically once CI passes label Nov 25, 2024
@yihau yihau merged commit f320175 into anza-xyz:master Nov 25, 2024
36 checks passed
@yihau yihau deleted the bump-ci-image-ubuntu-version branch November 25, 2024 18:32
mergify bot pushed a commit that referenced this pull request Nov 25, 2024
Co-authored-by: sakridge <[email protected]>
(cherry picked from commit f320175)
@@ -192,9 +192,9 @@ build() {
supported=("20.04")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! 🕵️ #3792

willhickey pushed a commit that referenced this pull request Nov 27, 2024
Co-authored-by: sakridge <[email protected]>
(cherry picked from commit f320175)
willhickey pushed a commit that referenced this pull request Nov 27, 2024
Co-authored-by: sakridge <[email protected]>
(cherry picked from commit f320175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.1 Backport to v2.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants