-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: introduce ci/docker/env.sh #3774
Conversation
I'm not sure how to review this for correctness nor security, so I'm removing myself as a reviewer. |
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
😱 New commits were pushed while the automerge label was present. |
automerge label removed due to a CI failure |
Co-authored-by: sakridge <[email protected]> (cherry picked from commit f320175)
@@ -192,9 +192,9 @@ build() { | |||
supported=("20.04") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! 🕵️ #3792
Co-authored-by: sakridge <[email protected]> (cherry picked from commit f320175)
Co-authored-by: sakridge <[email protected]> (cherry picked from commit f320175)
Problem
context: https://discord.com/channels/428295358100013066/560503042458517505/1310571536221995068
it's time to update our ci to ubuntu 22
Summary of Changes
ci/docker/env.sh