Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: cli: skip no-op program buffer writes (backport of #277) #308

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 18, 2024

Problem

When retrying a program deploy, a buffer account might have already been partially written to but the cli program deployer will try to write the entire buffer again, wasting time and transactions.

Summary of Changes

  • Before pushing a buffer write transaction, first check if the buffer data is already written with the desired data

Fixes #


This is an automatic backport of pull request #277 done by [Mergify](https://mergify.com).

cli: skip no-op program deploy write txs
(cherry picked from commit 2c12500)
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.22222% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 81.6%. Comparing base (e9bc805) to head (0a4c7a8).

Additional details and impacted files
@@           Coverage Diff           @@
##            v1.18     #308   +/-   ##
=======================================
  Coverage    81.6%    81.6%           
=======================================
  Files         827      827           
  Lines      224517   224535   +18     
=======================================
+ Hits       183263   183331   +68     
+ Misses      41254    41204   -50     

Copy link

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for backport since this is a cli-only (low-risk) change

@jstarry jstarry merged commit 5562d8d into v1.18 Mar 19, 2024
33 checks passed
@jstarry jstarry deleted the mergify/bp/v1.18/pr-277 branch March 19, 2024 23:51
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants