Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve theme PR check action #1659

Closed
5 tasks done
rickstaa opened this issue Mar 19, 2022 · 1 comment
Closed
5 tasks done

Improve theme PR check action #1659

rickstaa opened this issue Mar 19, 2022 · 1 comment
Labels
enhancement New feature or request. good first issue Good for newcomers. help wanted Extra attention is needed.

Comments

@rickstaa
Copy link
Collaborator

rickstaa commented Mar 19, 2022 •
edited
Loading

This issue replaces #1631, #1593 and #1637. I think the PR check action can be improved by:

  • Fixing the preview theme action Add prettier check to CI #1999.
  • Ensure that the preview theme action only runs when a theme is added ci: change theme-preview action run condition #1903.
  • Creating an error when a PR doesn't adhere to our guidelines. Only a warning is shown, but the action does not fail (see Update index.js #2057).
  • Automatically closing a PR that does not adhere to our theme guidelines. Only re-opening it if commits are pushed to the PR that makes the theme adhere.
  • Adding the ability to test multiple themes in the same PR.
@rickstaa rickstaa added the enhancement New feature or request. label Mar 19, 2022
@rickstaa rickstaa self-assigned this Mar 19, 2022
@rickstaa rickstaa removed their assignment Jul 6, 2022
@rickstaa rickstaa added help wanted Extra attention is needed. good first issue Good for newcomers. labels Jul 6, 2022
@rickstaa rickstaa mentioned this issue Sep 6, 2022
Closed
@rickstaa rickstaa mentioned this issue Sep 15, 2022
Closed
@rickstaa rickstaa mentioned this issue Sep 26, 2022
Closed
@rickstaa rickstaa linked a pull request Sep 26, 2022 that will close this issue
ci: improve theme-preview action #2060
Closed
@rickstaa
Copy link
Collaborator Author

rickstaa commented Oct 2, 2022

Implemented in #2065 and #2067.

@rickstaa rickstaa closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request. good first issue Good for newcomers. help wanted Extra attention is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: improve theme-preview action anuraghazra/github-readme-stats
1 participant
@rickstaa