Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 3d line plot #5471

Merged
merged 3 commits into from
Aug 30, 2023
Merged

feat: 3d line plot #5471

merged 3 commits into from
Aug 30, 2023

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Aug 28, 2023 •
edited
Loading

参考：https://plotly.com/javascript/3d-line-plots/
在 threedlib 中增加 line3D mark

image

TODO:

@coveralls
Copy link

coveralls commented Aug 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6011791806

  • 18 of 42 (42.86%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 88.553%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/shape/point3D/cube.ts 1 2 50.0%
src/shape/point3D/sphere.ts 1 2 50.0%
src/shape/line3D/line.ts 5 11 45.45%
src/mark/line3D.ts 8 24 33.33%
Totals Coverage Status
Change from base Build 6011150159: -0.3%
Covered Lines: 9808
Relevant Lines: 10720
💛 - Coveralls

@xiaoiver xiaoiver requested a review from pearmini August 29, 2023 05:56
@hustcc
Copy link
Member

hustcc commented Aug 29, 2023

image

当个文件的覆盖率还是需要提高一下~

@pearmini pearmini merged commit 4d157cd into v5 Aug 30, 2023
@pearmini pearmini deleted the feat-3d-barchart branch August 30, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaoiver @coveralls @hustcc @pearmini