Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: git clone failed on windows due to filename contains character : #5330

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

65min
Copy link
Contributor

@65min 65min commented Jul 19, 2023

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

windows环境下,从git上clone项目,由于部分文件名中含有冒号:,导致clone报错,错误信息如下:
image

@hustcc
Copy link
Member

hustcc commented Jul 19, 2023

@pearmini 看看 report 目录是否可以放到 ignore?这个目录应该是每次运行之后抛出来的临时文件吧?

@pearmini
Copy link
Member

@pearmini 看看 report 目录是否可以放到 ignore?这个目录应该是每次运行之后抛出来的临时文件吧?

其实感觉应该存下来,这个是记录性能数据的:

image

@hustcc
Copy link
Member

hustcc commented Jul 19, 2023

@pearmini 看看 report 目录是否可以放到 ignore?这个目录应该是每次运行之后抛出来的临时文件吧?

其实感觉应该存下来,这个是记录性能数据的:

image

@65min 那帮忙改改脚本,让生成的文件命名在 window 下也是合法的吧,麻烦了!代码在这里:https://github.com/antvis/G2/blob/v5/scripts/bench/server.ts#L14-L29

改成按天命名即可,不用带时分秒,文件命名覆盖内容即可。

@65min
Copy link
Contributor Author

65min commented Jul 19, 2023

@hustcc 已经修改了,后缀改成了yyyy-m-d格式。
另外gitignore也移除了/scripts/bench/reports目录。
现在/scripts/bench/reports目录下的几个文件,文件名日期后缀去除了时分秒。

@pearmini pearmini merged commit 682885b into antvis:v5 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants