Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear transform when animation finished #5277

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix: clear transform when animation finished #5277

merged 1 commit into from
Jul 6, 2023

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Jul 6, 2023

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change
  • 当 morphing 动画结束时,需要清除原始 Path 上的 transform。原因是在 convertToPath 时已经考虑了 transform,如果不清除会出现动画结束后 Path 位置偏移的现象。antvis/G@0eb5142
截屏2023-07-06 下午4 11 47
  • 移除多余的 scale(1, 1),现在可以直接通过设置 transform: 'none' 清空。

@xiaoiver xiaoiver requested a review from pearmini July 6, 2023 08:07
@pearmini pearmini merged commit db77f1b into v5 Jul 6, 2023
@pearmini pearmini deleted the fix-animation branch July 6, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants