From 245428fb48ca602a64f4c8b93a898a58a9603a57 Mon Sep 17 00:00:00 2001 From: lordforever Date: Mon, 25 Mar 2024 01:02:23 +0530 Subject: [PATCH] ui tests improvs --- build_system/src/test.rs | 8 ++++---- tests/failing-ui-tests.txt | 6 +++++- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/build_system/src/test.rs b/build_system/src/test.rs index 95c2f48516c..fc55a9d7687 100644 --- a/build_system/src/test.rs +++ b/build_system/src/test.rs @@ -839,8 +839,7 @@ fn should_remove_test(file_path: &Path) -> Result { "//@ run-fail", "-Cllvm-args", "//~", - "thread", - "//@ known-bug" + "thread" ] .iter() .any(|check| line.contains(check)) @@ -928,6 +927,7 @@ where let nb_parts = args.nb_parts.unwrap_or(0); if nb_parts > 0 { let current_part = args.current_part.unwrap(); + // FIXME: create a function "display_if_not_quiet" or something along the line. println!( "Splitting ui_test into {} parts (and running part {})", nb_parts, current_part @@ -1047,7 +1047,7 @@ fn prepare_files_callback_failing<'a>( move |rust_path| { let files = std::fs::read_to_string(file_path).unwrap_or_default(); let first_file_name = files.lines().next().unwrap_or(""); - // If the first line ends with a `/`, we treat it as a directory. + // If the first line ends with a `/`, we treat all lines in the file as a directory. if first_file_name.ends_with('/') { // Treat as directory // Removing all tests. @@ -1110,7 +1110,7 @@ fn prepare_files_callback_success<'a>( move |rust_path| { let files = std::fs::read_to_string(file_path).unwrap_or_default(); let first_file_name = files.lines().next().unwrap_or(""); - // If the first line ends with a `/`, we treat it as a directory. + // If the first line ends with a `/`, we treat all lines in the file as a directory. if first_file_name.ends_with('/') { if let Ok(files) = std::fs::read_to_string(file_path) { for file in diff --git a/tests/failing-ui-tests.txt b/tests/failing-ui-tests.txt index bb36ab4e8c3..404be25e8d0 100644 --- a/tests/failing-ui-tests.txt +++ b/tests/failing-ui-tests.txt @@ -72,4 +72,8 @@ tests/ui/type-alias-impl-trait/rpit_tait_equality_in_canonical_query.rs tests/ui/impl-trait/equality-in-canonical-query.rs tests/ui/consts/issue-miri-1910.rs tests/ui/mir/mir_heavy_promoted.rs - +tests/ui/consts/const_cmp_type_id.rs +tests/ui/consts/issue-73976-monomorphic.rs +tests/ui/consts/issue-94675.rs +tests/ui/rfcs/rfc-2632-const-trait-impl/const-drop-fail.r +tests/ui/rfcs/rfc-2632-const-trait-impl/const-drop.rs \ No newline at end of file