Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sensible default for success and failure URIs #14

Open
pledbrook opened this issue Jul 13, 2012 · 2 comments
Open

Use sensible default for success and failure URIs #14

pledbrook opened this issue Jul 13, 2012 · 2 comments

Comments

@pledbrook
Copy link
Contributor

At the moment, if you don't specify successUri and failureUri settings for a provider, you just end up with an exception. THe plugin should really use a sensible default if those settings haven't been provided.

I originally thought successUri should be '/' by default, but then that leaves a big question mark over the default for the failure URI. Perhaps the defaults should be /oauth/success and /oauth/failure? Then the controller could provide default action implementations.

@antony
Copy link
Owner

antony commented Jul 15, 2012

I reckon this is not a bad idea. At least then you'd have a differentiator. Not sure what format the default action should take though - perhaps a simple page like the Grails error page?

@pledbrook
Copy link
Contributor Author

I think a basic view that uses either the default application layout or 'main' would work. I think using 'main' layout is the best approach as not every project has a default application layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants