New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use methods instead of properties in ConnectionAsync.ts #4

Open

antonovicha opened this issue Sep 3, 2019 · 0 comments

Milestone

First usable version

Owner

antonovicha commented Sep 3, 2019

hdbext-async/ConnectionAsync.ts

Lines 18 to 20 in 56a1968

    
           public readonly exec: <T>(sql: string, params?: any[], options?: {}) => Promise<T>; 
        
           public readonly commit: () => Promise<void>; 
        
           public readonly rollback: () => Promise<void>;

Use methods instead of properties.
So that they can be easily mocked by ts-mockito or other framework.

antonovicha added this to the First usable version milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment