Fix type check for in operator with any on rhs

expr-lang · Jan 24, 2023 · c59a3b9 · c59a3b9
1 parent 93ff233
commit c59a3b9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/checker/checker.go b/checker/checker.go
@@ -316,7 +316,7 @@ func (v *visitor) BinaryNode(node *ast.BinaryNode) (reflect.Type, info) {
 		if isAny(l) && anyOf(r, isString, isArray, isMap) {
 			return boolType, info{}
 		}
-		if isAny(l) && isAny(r) {
+		if isAny(r) {
 			return boolType, info{}
 		}
 

diff --git a/checker/checker_test.go b/checker/checker_test.go
@@ -777,3 +777,14 @@ func TestCheck_cast_to_expected_works_with_interface(t *testing.T) {
 		require.NoError(t, err)
 	})
 }
+
+func TestCheck_operator_in_works_with_interfaces(t *testing.T) {
+	tree, err := parser.Parse(`'Tom' in names`)
+	require.NoError(t, err)
+
+	config := conf.New(nil)
+	expr.AllowUndefinedVariables()(config)
+
+	_, err = checker.Check(tree, config)
+	require.NoError(t, err)
+}