fix(terraform_docs): Fix non-GNU sed issues, introduced in v1.93.0

[cschroer]

Ensure compatibility of terraform_docs hook on MacOS and Linux by using GNU sed.

• This PR introduces breaking change.
• This PR fixes a bug.
• This PR adds new functionality.
• This PR enhances existing functionality.

Description of your changes

In PR #701, the usage of sed was introduced to the terraform_docs for in-file changes, resulting in #703

MacOS requires an extension for the -i parameter, unlike GNU sed.
As a result the hook fails on MacOS know with the following error:

Terraform docs..........................................................................Failed
- hook id: terraform_docs
- exit code: 1

sed: 1: "README.md": invalid command code R

I see two potential solutions for this issue.

1. Always pass a extension to the -i parameter, as this is compatible with GNU sed, too. As a result, a backup file would be created for each sed commands operation and needs to be deleted again.

2. Ensure we always use GNU sed. GNU sed is available via brew and can easily be installed on MacOS systems. Using GNU sed on both MacOS and Linux ensures consistent behaviour across operating systems.

I'm happy to change it to option 1, but wanted to show both options I see to fix the issue. Also I'm not 100% sure about Windows support for this hooks, but it seems like ( #648 ) they only work on Linux and MacOS.

[drAlberT]

@cschroer @MaxymVlasov @yermulnik there is a much more easy solution, variant of option 1 (I'm using it for many years and it is proven to be portable) ...

When you use "-i" in sed you must always add the backup suffix otherwise it would not work on Mac for example. Adding and empty suffix does the trick:

# bad
infra albert$ sed -i "s/^ASDDFGFDSGHSDFG$/PIPPOPIPPO/" "MODULE-DETAILS.md" 
sed: 1: "MODULE-DETAILS.md": invalid command code M

#good
infra albert$ sed -i "" "s/^ASDDFGFDSGHSDFG$/PIPPOPIPPO/" "MODULE-DETAILS.md"
infra albert$

This way no backup file is created, of course ;)

[MaxymVlasov]

And I suppose we need same fix in

pre-commit-terraform/README.md

Lines 585 to 590 in ad5d40b

	To migrate everything to `terraform-docs` insertion markers, run in repo root:
	```bash
	grep -rl 'BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK' . | xargs sed -i 's/BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK/BEGIN_TF_DOCS/g'
	grep -rl 'END OF PRE-COMMIT-TERRAFORM DOCS HOOK' . | xargs sed -i 's/END OF PRE-COMMIT-TERRAFORM DOCS HOOK/END_TF_DOCS/g'
	```

[cschroer]

I personally ran into some other issues with sed on MacOS, therefor I personally prefer using GNU sed on MacOS, too.
But for this case it's maybe better to simply use the empty extension. 👍 Adjusted the code and also updated the README.

[MaxymVlasov]

Also I'm not 100% sure about Windows support for this hooks, but it seems like ( #648 ) they only work on Linux and MacOS.

@cschroer yep, you're right
From installation instructions,

pre-commit-terraform/README.md

Lines 207 to 213 in 99fceb8

	<details><summary><b>Windows 10/11</b></summary>
	We highly recommend using [WSL/WSL2](https://docs.microsoft.com/en-us/windows/wsl/install) with Ubuntu and following the Ubuntu installation guide. Or use Docker.
	> [!IMPORTANT]
	> We won't be able to help with issues that can't be reproduced in Linux/Mac.
	> So, try to find a working solution and send PR before open an issue.

[antonbabenko]

This PR is included in version 1.93.1 🎉