-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling multiplatform support by moving to python #62
Comments
I started working on that and then found that someone had already written a script to transform the docs, which ought to be able to replace a large chunk of |
Very cool! Thanks for the links to those references. |
Not at all. I’m going to see if I can work on this and make it happen, since there’s more than just the conversion that’s written in Bash. |
terraform-docs/terraform-docs#113 is now moving forward, so I’ll wait for that to land first. |
Python works extremely slowly than bash. Some years ago I wrote my own hooks in python 3 and then rewrite it to sh. Same logic - x10 times faster If you do not use WSL in Windows, the better will be dockerize hooks, than rewrite it to python. In different systems installed different python versions - this will create many issues in the future. |
I agree, we won't prioritize support for multiplatform using Python. Bash or docker is better option. |
Is there any interest or appetite in porting the shell scripts to python to enable these pre-commit checks to work within environments where
bash
is not available, ex: windows?The text was updated successfully, but these errors were encountered: