Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling multiplatform support by moving to python #62

Closed
KyleOndy opened this issue Aug 30, 2019 · 6 comments
Closed

Enabling multiplatform support by moving to python #62

KyleOndy opened this issue Aug 30, 2019 · 6 comments

Comments

@KyleOndy
Copy link

Is there any interest or appetite in porting the shell scripts to python to enable these pre-commit checks to work within environments where bash is not available, ex: windows?

@Aankhen
Copy link

Aankhen commented Dec 11, 2019

I started working on that and then found that someone had already written a script to transform the docs, which ought to be able to replace a large chunk of terraform_docs.sh. See marcuscaisey’s comment in terraform-docs/terraform-docs#62.

@KyleOndy
Copy link
Author

Very cool! Thanks for the links to those references.

@Aankhen
Copy link

Aankhen commented Dec 12, 2019

Not at all. I’m going to see if I can work on this and make it happen, since there’s more than just the conversion that’s written in Bash.

@Aankhen
Copy link

Aankhen commented Dec 19, 2019

terraform-docs/terraform-docs#113 is now moving forward, so I’ll wait for that to land first.

@MaxymVlasov
Copy link
Collaborator

Python works extremely slowly than bash. Some years ago I wrote my own hooks in python 3 and then rewrite it to sh. Same logic - x10 times faster

If you do not use WSL in Windows, the better will be dockerize hooks, than rewrite it to python. In different systems installed different python versions - this will create many issues in the future.

@antonbabenko
Copy link
Owner

I agree, we won't prioritize support for multiplatform using Python. Bash or docker is better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants