rm token viewer from the preview panel and don't redraw parse tree for every input character. #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iven Control-hover show is the tokens, and it consumes fast CPU resources when there is a lot of input. Signed-off-by: Terence Parr <[email protected]>
…so kills any previous queue elements. Much better UI performance now. Reorg parse start code. Signed-off-by: Terence Parr <[email protected]>
|
Control-hover is easy to miss though, I didn't even know it existed :/ |
|
ha! Yeah I have to do a better job of advertising this. I’m going to make a video tutorial and maybe a quick list of the features as part of the documentation of ANTLR itself! This PR has the token view removed and does the queuing up of typing before creating a parse tree. Much much more responsive and even works with the huge ball of SQL. I still need to put the parsing in the background because it does pause the GUI thread too long |
…ntil they stop for a while. Signed-off-by: Terence Parr <[email protected]>
Signed-off-by: Terence Parr <[email protected]>
Signed-off-by: Terence Parr <[email protected]>
Signed-off-by: Terence Parr <[email protected]>
Signed-off-by: Terence Parr <[email protected]>
|
Fixes #546 |
|
Yeah I have to do a better job of advertising this. I’m going to make a
video tutorial! I have a PR that has the token view removed and does the
queuing up of typing before creating a parts tree. Much much more
responsive and even works with the huge ball of SQL. I still need to put
the parsing in the background because it does pause the Guo thread too long
On Thu, May 12, 2022 at 8:26 AM Bastien Jansen ***@***.***> wrote:
Control-hover is easy to miss though, I didn't even know it existed :/
—
Reply to this email directly, view it on GitHub
<#551 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABLUWPRNYYGNSCY3HVRMJTVJUPKBANCNFSM5VWSULSQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Dictation in use. Please excuse homophones, malapropisms, and nonsense.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rm token viewer from the preview panel how's it it's not necessary, given Control-hover show is the tokens, and it consumes fast CPU resources when there is a lot of input.
Even for 76k lines of SQL in input panel, seems ok. Parsing in background. Updating tree/hier views is 667ms even in intel rosetta mode (i think it is).
The MergingUpdateQueue allows us to avoid reparsing and also updating the parse tree upon each keystroke. If someone is typing, keep resetting timer so parsing doesn't start.
Signed-off-by: Terence Parr [email protected]