Fix case insensitive option with unicode, RANGE_PROBABLY_CONTAINS_NOT_IMPLIED_CHARACTERS fixes #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CHARACTERS_COLLISION_IN_SET warnings Don't report twice similar CHARACTERS_COLLISION_IN_SET warnings if caseInsensitive option enabled
…formation Length should be equal
Add CharactersDataCheckStatus
KvanTTT
force-pushed
the
case-insensitive-fixes
branch
from
be5c68a to
df62fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested our case insensitive grammars-v4 repository with enabled new option and have found some errors that are fixed by the current PR:
RANGE_PROBABLY_CONTAINS_NOT_IMPLIED_CHARACTERSonly for ASCII characters because there is probably not fully correct behavior with Unicode ranges. Anyway, I still think it's a useful warning, there are even questions on StackOverflow about[A-z]range: Difference between regex [A-z] and [a-zA-Z], [A-z0-9]+ regexp matching square brackets [duplicate]caseInsensitiveoption if only UPPER range length equals to lower range length