Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the ANTLR Maven plugin's antlr goal a skip parameter #2448

Open
thibgc opened this issue Dec 21, 2018 · 4 comments · May be fixed by #4266
Open

Give the ANTLR Maven plugin's antlr goal a skip parameter #2448

thibgc opened this issue Dec 21, 2018 · 4 comments · May be fixed by #4266

Comments

@thibgc
Copy link

thibgc commented Dec 21, 2018

According to https://www.antlr.org/api/maven-plugin/latest/antlr4-mojo.html the antlr goal has no skip parameter. A skip parameter that short-circuits the execution of the goal is a common idiom in Maven plugins, to allow for conditional execution.

@thibgc thibgc changed the title Give the ANTLR Maven plugin antlr goal a skip parameter Give the ANTLR Maven plugin's antlr goal a skip parameter Jan 3, 2019
@fbiville
Copy link

That would indeed be super convenient for multi-module projects, where the plugin is used in only a subset of the modules but these modules depend on other modules.
Basically, that would allow users to run:

./mvnw -am -pl :my-target-module antlr4:antlr4

And configure the plugin to skip at the parent POM level, so that all the resolved modules but my-target-module do nothing when the plugin is invoked.

@ericvergnaud
Copy link
Contributor

ericvergnaud commented May 12, 2023

I believe we would welcome such enhancement, if someone is willing to submit a PR

fbiville pushed a commit to fbiville/antlr4 that referenced this issue May 12, 2023
fbiville pushed a commit to fbiville/antlr4 that referenced this issue May 12, 2023
@fbiville fbiville linked a pull request May 12, 2023 that will close this issue
fbiville pushed a commit to fbiville/antlr4 that referenced this issue May 12, 2023
@fbiville
Copy link

@ericvergnaud I opened #4266 but I had local build issues that I'm not sure were related to the change I did

fbiville pushed a commit to fbiville/antlr4 that referenced this issue May 12, 2023
@jimidle
Copy link
Collaborator

jimidle commented May 13, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants