Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate Opt-in attributes #10

Open
Andrew-Hanlon opened this issue Sep 29, 2016 · 3 comments
Open

Alternate Opt-in attributes #10

Andrew-Hanlon opened this issue Sep 29, 2016 · 3 comments

Comments

@Andrew-Hanlon
Copy link

This is a fantastic tool, but I think one of the main barriers to wider adoption is the (perhaps unwarranted) fear of applying code re-writing across an entire codebase.

I think there would be a much larger/faster adoption of the tool if there was an additional set of attribute that allowed per-class or member opt-in vs. opt-out.

This could come in the form of an assembly level opt-out attribute (like the NoLinqRewriteAttribute at the assembly level), and an opt-in attribute at the class/member level (like a 'ApplyLinqRewriteAttribute').

I would be happy to create an initial PR if this was something that sounds acceptable.

@antiufo
Copy link
Owner

antiufo commented Sep 29, 2016

Yeah, nice idea.

@Andrew-Hanlon
Copy link
Author

Great. I'll put together a PR. One question, do you have the Shaman.Runtime.NoLinqRewriteAttribute exposed anywhere already, or is that left up to the implementer? It doesn't appear to be in the repo.

@antiufo
Copy link
Owner

antiufo commented Sep 29, 2016

It's up to the implementer, any attribute with that name will work. There's some sample code in the readme for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants