Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update critical dependency? #40

Open
khalwat opened this issue Jun 12, 2019 · 7 comments
Open

Update critical dependency? #40

khalwat opened this issue Jun 12, 2019 · 7 comments
Labels

Comments

@khalwat
Copy link

khalwat commented Jun 12, 2019

Any chance you might update the dependency to critical to ^2.0.0?

https://github.com/addyosmani/critical/blob/master/package.json#L3

@thescientist13
Copy link
Collaborator

Can take a look, not sure what breaking changes there are. I notice it is at 2.0.0-18, does that mean it is still in pre-release? Or just a custom versioning scheme?

@thescientist13
Copy link
Collaborator

thescientist13 commented Jun 15, 2019

I would add, we have Continuous Integration in place, so no harm in opening a PR if you feel up for it and we can see how that goes! 👍

@khalwat
Copy link
Author

khalwat commented Jun 28, 2019

Primary motivation is that older versions of Critical rely on packages that have security vulnerabilities.

@sanjayojha
Copy link

Why it is still not updated?

@thescientist13
Copy link
Collaborator

Maybe I can look into this soon, but PRs are also welcome. 👍

@jmartsch
Copy link

There is a PR for this here #48 but it was not merged yet.

@khalwat
Copy link
Author

khalwat commented Dec 27, 2020

FWIW, a drop-in replacement would be to use this one: https://github.com/lili21/critical-css-webpack-plugin

...which has been updated to use

"critical": "^2.0.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants