-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update critical dependency? #40
Comments
Can take a look, not sure what breaking changes there are. I notice it is at |
I would add, we have Continuous Integration in place, so no harm in opening a PR if you feel up for it and we can see how that goes! 👍 |
Primary motivation is that older versions of Critical rely on packages that have security vulnerabilities. |
Why it is still not updated? |
Maybe I can look into this soon, but PRs are also welcome. 👍 |
There is a PR for this here #48 but it was not merged yet. |
FWIW, a drop-in replacement would be to use this one: https://github.com/lili21/critical-css-webpack-plugin ...which has been updated to use "critical": "^2.0.0" |
Any chance you might update the dependency to critical to
^2.0.0
?https://github.com/addyosmani/critical/blob/master/package.json#L3
The text was updated successfully, but these errors were encountered: