Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taze strips all the comments out of my pnpm-workspace.yaml #131

Closed
5 of 7 tasks
dflock opened this issue Jul 23, 2024 · 1 comment
Closed
5 of 7 tasks

Taze strips all the comments out of my pnpm-workspace.yaml #131

dflock opened this issue Jul 23, 2024 · 1 comment

Comments

@dflock
Copy link
Contributor

dflock commented Jul 23, 2024

Describe the bug

When I ran taze after creating a pnpm-workspace.yaml file to use a catalog, taze stripped all the comments out of the yaml file.

When I said yes to "write to package.json", taze also re-wrote my pnpm-workspace.yaml file, normalizing the quoting of values - but also stripping out all the comments. There were no version changes made to anything in the catalog, so the workspace file didn't need to be touched at all.

Please don't strip out the comments - they're one of the best features of using yaml files for this, allowing me to document why I'm making these version choices, the purpose of the catalogs, etc...

Reproduction

https://github.com/dflock/taze-bug-repo

System Info

System:
    OS: Windows 10 10.0.19045
    CPU: (16) x64 Intel(R) Core(TM) i7-10700T CPU @ 2.00GHz
    Memory: 10.36 GB / 31.71 GB
  Binaries:
    Node: 20.15.1 - ~\scoop\apps\nodejs-lts\current\node.EXE
    npm: 10.7.0 - ~\scoop\apps\nodejs-lts\current\npm.CMD
    pnpm: 9.6.0 - ~\dev\photonic-web-ui\node_modules\.bin\pnpm.CMD
  Browsers:
    Edge: Chromium (126.0.2592.113)
    Internet Explorer: 11.0.19041.4355

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
@Wxh16144
Copy link

Wxh16144 commented Aug 5, 2024

I tried to fix this problem, but it is an upstream dependency error. There are many related discussions nodeca/js-yaml#689 (comment)

@antfu antfu closed this as completed in e84f668 Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants