Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make max_size=512 = set-able by user or 512 mandatory? Also can we save every generated image into outputs folder #73

Closed
FurkanGozukara opened this issue Dec 5, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@FurkanGozukara
Copy link

FurkanGozukara commented Dec 5, 2024

In the Gradio APP atm it is hard-coded to resize into 512

Can you let user to change it in the Gradio interface if possible?

Or 512 is mandatory? thank you

I also don't see generated images are not saved anywhere. Can you auto save every generated image into outputs folder?

@FurkanGozukara FurkanGozukara changed the title Can we make max_size=512 = set-able by user or 512 mandatory? Can we make max_size=512 = set-able by user or 512 mandatory? Also can we save every generated image into outputs folder Dec 5, 2024
@zliucz
Copy link
Member

zliucz commented Dec 5, 2024

Hi, there. Thanks for your interests on our project :). I've watched many of your videos, and many of them are inspiring.

Auto-resizing to 512 is not mandatory. You may check issues#36. Your suggestion to let user change the resizing resolution is brilliant. We'll adjust it in our next update.

The generated images will not be saved automatically. You may click the download icon to manually download it.
image

@FurkanGozukara
Copy link
Author

FurkanGozukara commented Dec 5, 2024

@zliucz can you add auto save? i certainly can fork and add but i really prefer to keep using your repo :)

and thank you so much. both features are asked by many people to me

i plan to make a tutorial for MagicQuill

@zliucz
Copy link
Member

zliucz commented Dec 5, 2024

Of course! Thanks for your suggestion:).

We’ll update these functions in our next version.

@bruceyyu bruceyyu added the enhancement New feature or request label Dec 6, 2024
@zliucz
Copy link
Member

zliucz commented Dec 6, 2024

Hi, there @FurkanGozukara. We have updated our code to implement these two features you've mentioned. Thank you again for your brilliant suggestions. Pull our latest code to try it out :).

截屏2024-12-06 18 30 14

@FurkanGozukara
Copy link
Author

@zliucz awesome ty

bigger res uses more vram though :D

do you think any quant or optimization possible?

image

@zliucz
Copy link
Member

zliucz commented Dec 6, 2024

@FurkanGozukara Indeed. We have already applied 4bit-quantization to the Draw&Guess LLaVA. We'll look into possible optimization strategies :).

@FurkanGozukara
Copy link
Author

@zliucz awesome

by the way i made it work on runpod and massed compute via cloudflared will make a tutorial soon hopefully

@zliucz
Copy link
Member

zliucz commented Dec 6, 2024

I'm glad to hear that, @FurkanGozukara. Let us know if you have further suggestions for our project.

I have always been a big fan of your YouTube channel ;) And I started my journey in generative AI by watching your tutorial about fine-tuning a LoRA. Thanks for your contribution to the community.

@zliucz zliucz closed this as completed Dec 6, 2024
@zliucz zliucz pinned this issue Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants