Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swiper): support RTL mode #6450

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RaHsu
Copy link

@RaHsu RaHsu commented Nov 23, 2023

ref: #6446
Swiper components support RTL

@@ -36,6 +36,10 @@ When you use a vertical Swiper, be sure to set its height through the `--height`

<code src="./demos/demo7.tsx" debug></code>

### rtl support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

写个demo 就够了,不必再起一行说明吧~

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,我把这里精简一下

Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6450.surge.sh

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (671ea15) 92.10% compared to head (d5f0b6b) 92.25%.
Report is 15 commits behind head on master.

❗ Current head d5f0b6b differs from pull request most recent head 7fa199d. Consider uploading reports for the commit 7fa199d to get more accurate results

Files Patch % Lines
src/components/swiper/swiper.tsx 88.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6450      +/-   ##
==========================================
+ Coverage   92.10%   92.25%   +0.15%     
==========================================
  Files         316      316              
  Lines        6861     6883      +22     
  Branches     1719     1743      +24     
==========================================
+ Hits         6319     6350      +31     
+ Misses        504      497       -7     
+ Partials       38       36       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaHsu RaHsu requested a review from 1587315093 November 23, 2023 09:27
@RaHsu
Copy link
Author

RaHsu commented Dec 7, 2023

@1587315093 修改过了,麻烦再review一下哇

@RaHsu
Copy link
Author

RaHsu commented Dec 21, 2023

@zombieJ 麻烦看一下呢,这个提交已经pending一个月了

@asd116725
Copy link

大佬们,什么时候合并一下这个需求,正好有阿拉伯语地区的适配需求,目前只能写死覆盖好几处direction: rtl;

@cbbfcd
Copy link
Contributor

cbbfcd commented Jun 5, 2024

大佬们,什么时候合并一下这个需求,正好有阿拉伯语地区的适配需求,目前只能写死覆盖好几处direction: rtl;

@zombieJ +1

@afc163
Copy link
Member

afc163 commented Jun 5, 2024

@asd116725 @cbbfcd 这个 PR 代码冲突了,需要 @RaHsu 解决一下先。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants