Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: wrong tagging on the coverage artifacts #3225

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 27, 2024

Description

The CICD was uploading all the remote testing as CentOS.

Issue linked

Close #3190

Checklist

@germa89 germa89 requested a review from a team as a code owner June 27, 2024 13:18
@germa89 germa89 added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Jun 27, 2024
@germa89 germa89 self-assigned this Jun 27, 2024
@germa89 germa89 removed the request for review from pyansys-ci-bot June 27, 2024 13:18
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 enabled auto-merge (squash) June 27, 2024 13:19
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (7c1eb1e) to head (0980625).
Report is 26 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (7c1eb1e) and HEAD (0980625). Click for more details.

HEAD has 110 uploads less than BASE | Flag | BASE (7c1eb1e) | HEAD (0980625) | |------|------|------| |minimal|20|2| |ubuntu|40|4| |local|40|4| |v24.1-ubuntu-student|12|2| |latest-ubuntu-student|12|2|
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3225      +/-   ##
==========================================
- Coverage   86.63%   80.21%   -6.43%     
==========================================
  Files          52       53       +1     
  Lines        9550     9625      +75     
==========================================
- Hits         8274     7721     -553     
- Misses       1276     1904     +628     

@germa89 germa89 changed the title Fix: wrong tagging on the coverage artifacts ci: wrong tagging on the coverage artifacts Jun 27, 2024
@germa89 germa89 merged commit 6153a6c into main Jun 28, 2024
44 checks passed
@germa89 germa89 deleted the fix/wrong-coverage-tagging-in-uploads branch June 28, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong coverage tagging
3 participants