-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: combine the docker-compose
files
#3169
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3169 +/- ##
===========================================
- Coverage 86.63% 63.22% -23.42%
===========================================
Files 52 52
Lines 9550 9596 +46
===========================================
- Hits 8274 6067 -2207
- Misses 1276 3529 +2253 |
Thank you a lot for this PR! You make thought and google a bit... it seems now https://docs.docker.com/compose/profiles/?highlight=profile I will take the freedom to modify your PR to adapt to those profiles. |
sure, no problem |
Forcing to use a service name or profile. There is no default because `mapdl` and `mapdl-local` are both excluding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you a lot @Revathyvenugopal162 for this.
Thanks @germa89 , i will merge the PR if its ok (pinging @jorgepiloto ) once the workflow finishes. |
Description
This PR merges three separate Docker Compose files into a single Docker Compose file containing three distinct services:
mapdl
,dpf
, andmapdl-local
.To start a specific service, use the following command:
For example, to start the mapdl service, run:
This consolidation simplifies the management and orchestration of our Docker services, making it easier to start, stop, and manage the individual components as needed.