Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding context manager to MapdlPool #3047

Merged
merged 11 commits into from
May 3, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 30, 2024

As the title

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 requested review from clatapie and koubaa April 30, 2024 10:32
@germa89 germa89 self-assigned this Apr 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 27.58621% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 81.02%. Comparing base (5442a4e) to head (0224d9f).
Report is 3 commits behind head on main.

❗ Current head 0224d9f differs from pull request most recent head 108f7ba. Consider uploading reports for the commit 108f7ba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3047      +/-   ##
==========================================
- Coverage   86.63%   81.02%   -5.62%     
==========================================
  Files          52       52              
  Lines        9498     9525      +27     
==========================================
- Hits         8229     7718     -511     
- Misses       1269     1807     +538     

@germa89 germa89 enabled auto-merge (squash) May 3, 2024 08:14
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit c153050 into main May 3, 2024
31 checks passed
@germa89 germa89 deleted the feat/adding-mapdlpool.next-context-manager branch May 3, 2024 09:12
@clatapie clatapie changed the title Adding context manager to MapdlPool feat: adding context manager to MapdlPool Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants