Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating corba in docs #2639

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Deprecating corba in docs #2639

merged 4 commits into from
Jan 11, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 10, 2024

As the title.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 requested a review from clatapie January 10, 2024 11:15
@germa89 germa89 self-assigned this Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (46a18c6) 81.07% compared to head (73bc7e6) 82.27%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2639      +/-   ##
==========================================
+ Coverage   81.07%   82.27%   +1.20%     
==========================================
  Files          47       47              
  Lines        9340     9344       +4     
==========================================
+ Hits         7572     7688     +116     
+ Misses       1768     1656     -112     

@germa89
Copy link
Collaborator Author

germa89 commented Jan 11, 2024

@pyansys-ci-bot LGTM.

pyansys-ci-bot

This comment was marked as outdated.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit a9cb416 into main Jan 11, 2024
28 of 29 checks passed
@germa89 germa89 deleted the doc/corba-deprecation-mesage branch January 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants