Moving functions to Mapdl class #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Adding `mapdl` (lowercase) to accepts. Fixing other warnings.
…ub.com/pyansys/pymapdl into feat/moving-functions-to-mapdl-classes
germa89
changed the title
germa89
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2468 +/- ##
==========================================
+ Coverage 83.83% 83.88% +0.04%
==========================================
Files 44 44
Lines 8685 8749 +64
==========================================
+ Hits 7281 7339 +58
- Misses 1404 1410 +6 |
|
Still waiting for a review on this... @clatapie |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all the non-default code in
Commands_class to childMapdlclass.Close #2434