-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing unique session id #1912
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat/unique_session_id
github-actions
bot
added
CI/CD
Related with CICD, Github Actions, etc
Maintenance
labels
Mar 13, 2023
Please add one of the following labels to add this contribution to the Release Notes 👇 |
Codecov Report
@@ Coverage Diff @@
## main #1912 +/- ##
==========================================
+ Coverage 80.82% 87.10% +6.28%
==========================================
Files 44 45 +1
Lines 7489 8052 +563
==========================================
+ Hits 6053 7014 +961
+ Misses 1436 1038 -398 |
koubaa
approved these changes
Apr 26, 2023
Fixing elif condition always false (never check ids during testing). Increasing coverage
germa89
commented
Jul 4, 2023
Improving retrieve_file function by doing a slightly later exit.
…ymapdl into feat/unique_session_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should improve stability. Let's see.
Current situation
CICD fails because the docker image crashes quite frequently. We automatically reboot it (
--restart always
docker flag), but then the image comes with no data, clean.But PyMAPDL is not aware that the database has been cleaned hence it request data which gives errors of different kind.
Approach
In this PR, I have implemented a session id unique for each PyMAPDL connection. Everytime it connects to a MAPDL session, using
_connect
method, it will fix a session ID. Also, when we issuemapdl.clear
.Every time we issue
mapdl.run
we check that the ids are the same in the client and in the server (only at testing). If they are not, I raise an issue which is catched by pytests, and re-run the test completely.Opinion
I think the idea is good. But ideally we want to implement something that checks the health of the gRPC channel.
So far, I'm going to test this, and consider late:
Close #1915