Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: adding student back #3623

Merged
merged 4 commits into from
Dec 13, 2024
Merged

ci: adding student back #3623

merged 4 commits into from
Dec 13, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 13, 2024

Description

We need to fix some required checks on CICD.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner December 13, 2024 16:50
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the CI/CD Related with CICD, Github Actions, etc label Dec 13, 2024
@github-actions github-actions bot added the maintenance General maintenance of the repo (libraries, cicd, etc) label Dec 13, 2024
@germa89 germa89 self-assigned this Dec 13, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Dec 13, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) December 13, 2024 17:12
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.02%. Comparing base (1473bdd) to head (bb3a690).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3623      +/-   ##
==========================================
+ Coverage   86.97%   87.02%   +0.04%     
==========================================
  Files         187      187              
  Lines       14630    14661      +31     
==========================================
+ Hits        12725    12759      +34     
+ Misses       1905     1902       -3     

@germa89 germa89 merged commit b5e482a into main Dec 13, 2024
61 of 62 checks passed
@germa89 germa89 deleted the ci/adding-student-back-to-required branch December 13, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants