-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: console launching #3586
fix: console launching #3586
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3586 +/- ##
==========================================
- Coverage 86.97% 86.96% -0.02%
==========================================
Files 187 187
Lines 14630 14661 +31
==========================================
+ Hits 12725 12750 +25
- Misses 1905 1911 +6 |
This PR was tested on the container, meaning we should be able to test the console mode on the CICD. #ForTheFuture |
Since the support for console is minimal for the moment, I'm not caring about coverage so far. |
Pinging @koubaa for awareness. |
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Some fixes for the console mode
Issue linked
This does not mean we are raising the support level to the grpc interface. But I prefer to have something half-functional.
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)