Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: console launching #3586

Merged
merged 8 commits into from
Dec 13, 2024
Merged

fix: console launching #3586

merged 8 commits into from
Dec 13, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 27, 2024

Description

Some fixes for the console mode

Issue linked

This does not mean we are raising the support level to the grpc interface. But I prefer to have something half-functional.

Checklist

@germa89 germa89 requested a review from a team as a code owner November 27, 2024 17:56
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 27, 2024 17:56
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 27, 2024
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.96%. Comparing base (1473bdd) to head (a332928).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3586      +/-   ##
==========================================
- Coverage   86.97%   86.96%   -0.02%     
==========================================
  Files         187      187              
  Lines       14630    14661      +31     
==========================================
+ Hits        12725    12750      +25     
- Misses       1905     1911       +6     

@germa89 germa89 changed the title fix: console launching and at least one test. fix: console launching Nov 28, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Nov 28, 2024

This PR was tested on the container, meaning we should be able to test the console mode on the CICD. #ForTheFuture

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Dec 13, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Dec 13, 2024

Since the support for console is minimal for the moment, I'm not caring about coverage so far.

@germa89
Copy link
Collaborator Author

germa89 commented Dec 13, 2024

Pinging @koubaa for awareness.

@germa89
Copy link
Collaborator Author

germa89 commented Dec 13, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 076d722 into main Dec 13, 2024
54 of 56 checks passed
@germa89 germa89 deleted the fix/console branch December 13, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants