Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: annotate pymapdl part 1 #3569

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 22, 2024

Description

Annotate some files

Issue linked

Related to #3480

Checklist

@germa89 germa89 requested a review from a team as a code owner November 22, 2024 12:41
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 22, 2024 12:41
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 22, 2024
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Nov 22, 2024
@germa89 germa89 mentioned this pull request Nov 22, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Nov 22, 2024

@ansys-reviewer-bot review

@ansys-reviewer-bot
Copy link
Contributor

Okay, I will trigger a review of your PR.

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/ansys/mapdl/core/cli/stop.py Outdated Show resolved Hide resolved
@germa89
Copy link
Collaborator Author

germa89 commented Nov 22, 2024

Okay, I will trigger a review of your PR.

... so?

@RobPasMue

@RobPasMue
Copy link
Member

@ansys-reviewer-bot review

@germa89 germa89 added the DO NOT MERGE Not ready to be merged yet label Nov 22, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 99.30070% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.15%. Comparing base (afad43e) to head (9008021).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3569      +/-   ##
==========================================
+ Coverage   86.97%   87.15%   +0.17%     
==========================================
  Files         187      187              
  Lines       14623    14627       +4     
==========================================
+ Hits        12719    12748      +29     
+ Misses       1904     1879      -25     

src/ansys/mapdl/core/commands.py Dismissed Show dismissed Hide dismissed
@germa89
Copy link
Collaborator Author

germa89 commented Dec 13, 2024

@RobPasMue any news about the bot?

@germa89
Copy link
Collaborator Author

germa89 commented Dec 13, 2024

@ansys-reviewer-bot review

@ansys-reviewer-bot
Copy link
Contributor

Okay, I will trigger a review of your PR.

@RobPasMue
Copy link
Member

@RobPasMue any news about the bot?

Nope - too many parallel tracks currently

@germa89
Copy link
Collaborator Author

germa89 commented Dec 16, 2024

@RobPasMue any news about the bot?

Nope - too many parallel tracks currently

Roger that... you tell me... this PR is no priority and if you think it is a good test for the bot (since it is just annotating... no other logic)... I can keep it open... or go ahead... up to you.

@RobPasMue
Copy link
Member

Go ahead... don't wait for me. Sorry @germa89

@germa89
Copy link
Collaborator Author

germa89 commented Dec 16, 2024

Go ahead... don't wait for me. Sorry @germa89

No big deal at all! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Not ready to be merged yet enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants