-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation issues with pyvista #28
Comments
For the moment, keep with |
I guess there are larger changes to be expcted for plotting, but if you want a short-term fix in your own environment, I think you only need to add it to |
The general plotter is used for the core library plots, but the function I modified were contained withing the reader. |
Fixed in #29. Theme based changes will be pushed when updating to Since this is a critical bug with the latest |
While fooling around with the functions
plot_nodal_solution()
andanimate_nodal_solution()
I've gotten some small issues due to changes in pyvista:With
plot_nodal_solution()
it raises an error due to the use ofstitle
as a keyword, instead of the suggested use of '''scalar_bar_args={'title': 'Scalar Bar Title'}'''. This is just a warning, so the function works and plots correctly.With
animate_nodal_solution()
it raises a DeprecationError due to the use of use_ipyvtk instead of the ipyvtklink backend. The animation doesn't render.From what I've gathered looking into the code, the first issue is present in various functions, while the second appears only in
_plot_point_scalars()
(which I was taking a look in order to add a return_plotter keyword), but I'm not comfortable enough yet with pyvista to fix and PR myselfThe text was updated successfully, but these errors were encountered: