Mount the PyFluent working directory to Docker containers by default #2867
Labels
discussion
enhancement
New feature or request. Feature work invariably requires testing-team involvement
Ever since #359 we have been working with Fluent containers mounted to
pyfluent.EXAMPLES_PATH
in the host system. This was apparently fine as until recently, PyFluent with Fluent containers was mainly being used for the PyFluent CI and not many people external to the PyFluent team were using PyFluent with Fluent containers as well.Evidently, as seen in the recent uptick in user questions and bug reports related to Fluent containers, more and more people are using PyFluent with Fluent containers.
I do not believe that mounting the
pyfluent.EXAMPLES_PATH
to the Fluent container by default is useful or intuitive to users. I would suggest that this be reconsidered, and changed so that the current PyFluent working directory is mounted to the Fluent container working directory. In this way, both PyFluent and Fluent would be working in the exact same working directory (though each one sees it with a different absolute path). Note that currently PyFluent launches standalone Fluent by default also in the current PyFluent working directory, so this would mean the docker and standalone launchers would have behavior that is more similar to each other.For the CI, I believe this means changes would also need to be made to the
examples.download_file()
method to make things seamless, as it is currently downloading topyfluent.EXAMPLES_PATH
by default, and it should then download to the current working directory (which is also more intuitive IMO).This would also break scripts from the users that may already be relying on this (odd) behavior of PyFluent mounting containers to the absolute path of
pyfluent.EXAMPLES_PATH
(and downloading example files to there as well).Overall, I believe this would be a lot more intuitive to users. This change, with the changes for #2865, should make using PyFluent with Fluent containers a lot more user friendly.
In addition, making the example configuring
launch_fluent()
withhost_mount_path
more prominent would probably also be helpful (maybe adding more examples like that as well, now that Fluent containers seems to be a more common use-case).@mkundu1 @hpohekar @prmukherj @seanpearsonuk
The text was updated successfully, but these errors were encountered: