Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMISC and SMISC retrocompatibility break #1438

Closed
3 tasks done
PProfizi opened this issue Feb 23, 2024 · 6 comments
Closed
3 tasks done

NMISC and SMISC retrocompatibility break #1438

PProfizi opened this issue Feb 23, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@PProfizi
Copy link
Contributor

Before submitting the issue

  • I have checked for Compatibility issues
  • I have searched among the existing issues
  • I am using a Python virtual environment

Description of the bug

Operators dpf.operators.result.nmisc and dpf.operators.result.smisc in PyDPF-Core 0.11.0 are not retro-compatible with DPF servers below 2024.2.pre0 due to breaking changes server-side.
We need to see how to properly manage that.

Steps To Reproduce

NA

Which Operating System causes the issue?

Windows, MacOS, Linux

Which DPF/Ansys version are you using?

Ansys 2024 R1

Which Python version causes the issue?

3.11

Installed packages

NA

@PProfizi PProfizi added the bug Something isn't working label Feb 23, 2024
@PProfizi PProfizi self-assigned this Feb 23, 2024
@PProfizi
Copy link
Contributor Author

@germa89
Copy link
Contributor

germa89 commented Feb 27, 2024

@kmahajan-cadfem
Copy link
Contributor

I have also just noticed it, would this be addressed or the existing scripts have to be changed for future compatibility?

@germa89
Copy link
Contributor

germa89 commented Apr 26, 2024

Any update on this?? @PProfizi @rafacanton

@germa89
Copy link
Contributor

germa89 commented Aug 27, 2024

Any update on this?? @PProfizi @rafacanton

Are they any plans to bring back those operators? If not, we should close this issue.

@rafacanton
Copy link
Contributor

@germa89 Unfortunately we broke retro with a mistake and the operators will not be available again. I think that in client applications for this result you can do an ugly if based on the dpf version (which you can know doing a dpf.global_server().version):

  • If dpf version >= 8.0 ( = 24.2.pre0 as per this table) the internal operator to be run should be "NMISC"/"SMISC", which is mapped to the regular dpf.operators.result.nmisc/dpf.operators.result.smisc.
  • For older versions, the internal operator to be run should be "mapdl::nmisc"/"mapdl::smisc", which are always accessible in that versions through the less Pythonic APIs dpf.Operator("mapdl::nmisc")/dpf.Operator("mapdl::smisc").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants