-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ccpansys/solutions e2e testing #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor suggestions
@nick-marnik, @jacobevansgit: Thank you for your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ccpansys This build triggered on a different PR and it looks like the secret may not exist: https://github.com/ansys/ansys-templates/actions/runs/6746000959/job/18338968194 Based on line 9, are you sure that |
@nick-marnik That is surprising. The workflow has run with that token before, so it must exist (or it did, at least). And I am afraid I don't have permissions to check, either. @iazehaf, can you help us figure this one out? |
I just checked and @ccpansys is correct, this build has run successfully in the past: https://github.com/ansys/ansys-templates/actions/workflows/solutions_ci.yml I am just speculating, but I suspect this may be related to my permissions on this repo. Comparing the successful builds to my failed build, the difference is that my PR is based off of a branch from my personal fork of this repository. At one point in time, I correctly had write permissions for this repo and was able to push my branch directly. However, somewhere along the way of the public/private migrations of this repo, my permissions were broken and I was relegated to using a fork. Paging @jacobevansgit for comment PR in question: #365 |
Sorry @nick-marnik @ccpansys I am also not admin of this org. Please reach out to Pyansys colleagues. However after looking at this PR again, I am wondering if we should have this open repo signalling to start tests inside our internal org. The more appropriate way for this to scale would be to have the tests repo "listen" to this repository ( Updating the |
I don't disagree with your premise, but unfortunately I am not aware of a way to achieve this behavior. Currently, @jorgepiloto Do you have any idea what could be happening with the secret mentioned above? |
Hi @nick-marnik. I can confirm that the secret |
I don't have access to see this, either, but I assume it is configured correctly because it works for some builds. Are my permissions on this repo correct? I am curious if testing with a non-forked branch would yield different results. |
This PR adds a workflow file that will trigger the solution templates e2e tests on each PR that modifies one of the Solution templates.