Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit to dev dependency group in Poetry template #219

Open
da1910 opened this issue Feb 2, 2023 · 1 comment
Open

Add pre-commit to dev dependency group in Poetry template #219

da1910 opened this issue Feb 2, 2023 · 1 comment
Labels
enhancement New features or code improvements

Comments

@da1910
Copy link
Contributor

da1910 commented Feb 2, 2023

📝 Description of the feature

Poetry projects created with this template work great, but poetry install does not play nicely with pre-commit run. Poetry removes packages that are not in the lock file, and pre-commit installs PyYAML amongst other things, this is then removed on subsequent invocations of poetry install will uninstall one or more dependencies of pre-commit

💡 Steps for implementing the feature

Add pre-commit as an entry in the [tool.poetry.group.dev.dependencies] group

🔗 Useful links and references

No response

@greschd
Copy link
Member

greschd commented Feb 2, 2023

I can provide links to (internal) projects using this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

No branches or pull requests

2 participants