Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to pulpcore 3.11 + Proxy username and password are now separated fields. #678

Merged
merged 4 commits into from
Mar 16, 2021
Merged

upgrade to pulpcore 3.11 + Proxy username and password are now separated fields. #678

merged 4 commits into from
Mar 16, 2021

Conversation

rochacbruno
Copy link
Member

@rochacbruno rochacbruno commented Mar 11, 2021 •
edited
Loading

  • Reverted the PR that splitted those fields
  • Deleted utils added for that PR
  • Pulcore updated to 3.11
  • Adjusted serializers
  • Fixed test cases
  • make requirements
  • removed ALLOWED_CONTENT_CHECKSUM settings

Issue: AAH-425

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@rochacbruno rochacbruno requested a review from newswangerd March 11, 2021 19:55
@rochacbruno rochacbruno marked this pull request as draft March 12, 2021 19:44
@rochacbruno rochacbruno marked this pull request as ready for review March 16, 2021 20:06
@rochacbruno rochacbruno changed the title Proxy username and password are now separated fields. upgrade to pulpcore 3.11 + Proxy username and password are now separated fields. Mar 16, 2021
@rochacbruno
Proxy username and password are now separated fields.
68189ea 
- Reverted the PR that splitted those fields
- Deleted utils added for that PR
- Adjusted serializers
- Fixed test cases

Issue: AAH-425
@rochacbruno
username and proxy_username is not write_only
3b76b87 
Issue: AAH-425
@rochacbruno rochacbruno requested a review from awcrosby March 16, 2021 20:30
awcrosby
awcrosby suggested changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@awcrosby awcrosby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove this as part of upgrade to 3.11:
https://github.com/ansible/galaxy_ng/blob/master/galaxy_ng/app/settings.py#L82

@rochacbruno
make requirements
d7506ef 
Issue: AAH-425
@rochacbruno rochacbruno requested a review from awcrosby March 16, 2021 20:57
awcrosby
awcrosby approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@awcrosby awcrosby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rochacbruno rochacbruno merged commit 4c3d166 into ansible:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awcrosby awcrosby awcrosby approved these changes

@newswangerd newswangerd newswangerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rochacbruno @app-sre-bot @awcrosby @newswangerd