-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add make targets for common tasks on dev env and support for env snapshots #667
Conversation
snapshots This PR is addresses AAH-387 adding more targets to Makefile Also some tweaks to Docker files and setup.py to enable running specific deps branches. Adds ability to set a global `suffix` so it is possible to have multiple environments already built and saved (snapshots) Adds utilities to run 2 instances of AAH in the same host. Issue: AAH-387
Can one of the admins verify this patch? |
I think it just has to run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice job
6fcf317
to
03af3fe
Compare
Issue: AAH-387
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Assuming it works for an existing checking without any manual intervention. If it does need some manual intervention, need some docs about it (I may have missed them).
@rochacbruno I got this when running anything
I tried |
This PR is addresses AAH-387 adding more targets to Makefile
Also some tweaks to Docker files and setup.py to enable running specific
deps branches.
LOCK_REQUIREMENTS
is disabled, all deps listed onDEV_SOURCE_PATH
is unppined onsetup.py
Adds ability to set a global
suffix
so it is possible to have multipleenvironments already built and saved (snapshots)
Build and run environment to work on specific issue
Build and run environment to work on specific issue
./compose stop export DEV_IMAGE_SUFFIX=fixing_an_urgent_issue ./compose build ./compose up
Now you can switch the state of
DEV_IMAGE_SUFFIX
to use whichever environment state you want, (a.k.a snapshot)Issue: AAH-387