-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new entrypoint cmd per guidance from Pulp team #2105
Use new entrypoint cmd per guidance from Pulp team #2105
Conversation
/retest |
Do these changes require a newer version of pulp? Because the pods are failing with: |
those changes are needed because of f80ef95#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R115 However, the cli path is probably wrong in this PR because pulpcore should be installed in the virtual environmant under |
0a278f8
to
b28a993
Compare
I just updated the PR with the correct path to
Maybe we need to re-trigger CI to see if it is flake? I don't have permission to do so. |
/retest |
b28a993
to
033954e
Compare
@rochacbruno it was failing when deploying with the galaxy-operator with this error:
So with the new changes, it needs to be:
as per: This latest push should fix it. |
63e466a
to
131f9c2
Compare
I just built a galaxy-ng image from this branch and tested it out with the operator and it now works:
Caveat: I had to remove this flag because the pulpcore-api script didn't allow it, I think the pulp team may need to add a click option for this, I'll talk with them about this.
|
No-Issue Signed-off-by: Christian M. Adams <[email protected]>
131f9c2
to
05c407f
Compare
@rochacbruno I think we should merge this PR as is. I expect the tests to pass shortly. While testing this, I ran in to another bug, pulpcore-api does not correctly handle the
|
What is this PR doing:
In this pulpcore PR, the entrypoint for api and content containers as changed.
In the changelog, they advise:
I have removed the
--worker-class
flag as it is now handled automatically in the entrypoint script (here).This PR is a best effort, as I don't know the galaxy_ng project as well. Please feel free to close and replace with your own PR or request changes. Thanks!
Reviewers must know:
PR Author & Reviewers: Keep or remove backport labels per Backporting Guidelines
Reviewers: Look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit