Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert post-deploy-test to jenkins webhook #1158

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

drodowic
Copy link
Collaborator

@drodowic drodowic commented Mar 2, 2022

Issue: AAH-1212

Description 🛠

Convert the post-deploy-test that runs after a stage deploy from a ClowdJobInvocation to a Job that issues a webhook to kick off the IQE tests via Jenkins.

Reviewer Checklists 👀

Developer reviewer:

  • Code looks sound, good architectural decisions, no code smells
  • There is a Jira issue associated (note that "No-Issue" should be rarely used)
  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed

QE reviewer (exceptions):

  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed
  • PR meets applicable Acceptance Criteria for associated Jira issue

Note: when merging, include the Jira issue link in the squashed commit

@drodowic drodowic requested a review from hendersonreed March 3, 2022 13:18
@hendersonreed
Copy link
Contributor

This looks good - I'm not an expert on this type of job but it all looks right to me!

@drodowic drodowic merged commit 2b25c9c into ansible:master Mar 4, 2022
@drodowic drodowic deleted the deploy-acceptance-job branch March 4, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants