-
Notifications
You must be signed in to change notification settings - Fork 45
ensure we built images using both x64 and aarch64 architecture #7
Comments
I implemented this for pylibssh in the past, happy to do the same here. |
Would now be a good time to work on this? |
@ziegenberg Obviously! you have my support. I just did not know how to do it with GHA. |
@mattclay @nitzmahone As I seen the work on new container building at https://github.com/ansible/base-test-container lets have a talk so we can decide what is the easiest path for @ansible/devtools team to build and publish multiple architectures for for creator-ee. |
@ssbarnea do you need help updating the GitHub workflow? |
@kmf What needs to be done is bit more complex but if you can link to an existing GHA workflow which builds and publishes a dual-arch container, it could clearly help with this task. |
We're already doing this with all the ansible-test containers using containmint so the builds are happening on real aarch64 hardware instead of hella slow emulation. It's a little harder to do securely from GHA because the GHA secret stuff is a lot jankier than AZP and there's no Core CI GHA job support, so you need to keep the ansible-core-ci key secret. Take a look at https://github.com/ansible/default-test-container/blob/main/azure-pipelines.yml - it's pretty trivial. |
... and as for builder and EEs, once the vanilla base image support is done, builder itself shouldn't need any special support to do non-x86 containers (though there might be a couple minor convenience things like build arch arg passthrus to the underlying container runtime if someone is configured for foreign arch emulated builds or whatever). |
That's using emulated builds though. It looks like an arch-native release build on |
I sorted the performance issue by creating a pip install runs quite fast, even with QEMU virtualization, so no problem here. Since yesterday with |
As aarch64 architecture is becoming more popular every day, we should ensure that we built multi-platform images, so everyone can make use of them.
See https://github.com/docker/build-push-action/blob/master/docs/advanced/multi-platform.md for
a potential solution to this issue.
docker buildx
Depends-On: ansible/ansible-runner#1046
Depends-On: ansible/ansible-builder#373
The text was updated successfully, but these errors were encountered: