Allow wsrelay to fail without FATAL #15191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gundalow
reviewed
May 15, 2024
gundalow
reviewed
May 15, 2024
TheRealHaoLiu
force-pushed
the
allow-wsrelay-to-fail
branch
2 times, most recently
from
2dba9a9
to
1a801c6
Compare
TheRealHaoLiu
force-pushed
the
allow-wsrelay-to-fail
branch
from
1a801c6
to
daa19a9
Compare
chrismeyersfsu
approved these changes
May 17, 2024
We have not identify the root cause of wsrelay failure but attempt to make wsrelay restart itself resulted in postgres and redis connection leak. We were not able to fully identify where the redis connection leak comes from so reverting back to failing and removing startsecs 30 will prevent wsrelay to FATAL
TheRealHaoLiu
force-pushed
the
allow-wsrelay-to-fail
branch
from
daa19a9
to
1a9f2a2
Compare
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
We have not identify the root cause of wsrelay failure but attempt to make wsrelay restart itself resulted in postgres and redis connection leak. We were not able to fully identify where the redis connection leak comes from so reverting back to failing and removing startsecs 30 will prevent wsrelay to FATAL
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
We have not identify the root cause of wsrelay failure but attempt to make wsrelay restart itself resulted in postgres and redis connection leak. We were not able to fully identify where the redis connection leak comes from so reverting back to failing and removing startsecs 30 will prevent wsrelay to FATAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Reverting previous change that prevents wsrelay from failing and restart processes internally.
We have not identify the root cause of wsrelay failure but attempt to make wsrelay restart itself resulted in postgres and redis connection leak. We were not able to fully identify where the redis connection leak comes from so reverting back to failing and removing startsecs 30 will prevent wsrelay to FATAL
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION